ed255/pod2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unnecessary mut in PodSigner trait (#340)

Browse source 
The PodSigner trait was taking `&mut self` in the `sign` method, but the
signer doesn't need mutation in the Shcnorr implementation.  Remove the
`mut`.

Previously the PodProver trait was also taking `&mut self` in the
`prove` method, and we had many tests creating a `mut Prover/mut
MockProver`.  Remove all those `mut`.

Breaking change: `PodSigner` trait method `sign` replaces `&mut self` by
`&self`
This commit is contained in:
Eduard S. 2025-07-15 17:37:26 +02:00 • committed by GitHub
parent b5e0d97cb6
commit 63a716ebd7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 136 additions and 146 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/frontend/custom.rs
View file

@ -311,8 +311,8 @@ mod tests {
mp_builder.pub_op(op!(custom, gt_custom_pred, desugared_gt))?;
// Check that the POD builds
let mut prover = MockProver {};
let proof = mp_builder.prove(&mut prover, &params)?;
let prover = MockProver {};
let proof = mp_builder.prove(&prover, &params)?;
Ok(())
}
@ -360,8 +360,8 @@ mod tests {
let set_contains_custom_pred = CustomPredicateRef::new(batch, 0);
mp_builder.pub_op(op!(custom, set_contains_custom_pred, set_contains))?;
let mut prover = MockProver {};
let proof = mp_builder.prove(&mut prover, &params)?;
let prover = MockProver {};
let proof = mp_builder.prove(&prover, &params)?;
Ok(())
}